Add task_clock as additional counter used with perf counters #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlb6740
force-pushed
the
add-task-clock-counter
branch
from
5e26257 to
b76aa9d
Compare
Currently all of sightglass's measuring units are tied processor events which is only useful in comparing performance where the cpu remains constant. This patch adds cpu time software counter as calculated by the kernel.
fitzgen
approved these changes
Jan 3, 2023
Member
|
The CI failure looks like we need to update our rustc in CI. |
Member
|
#218 should fix the CI issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all of sightglass's measuring units are tied processor events which is only useful in comparing performance where the cpu remains constant. This patch adds cpu time software counter as calculated by the kernel.