don't combine stream/future ctors so aggressively - #249
Merged
Conversation
Previously, we would only emit one such constructor function per future or stream "canonical" payload type, where canonicalization would combine structurally equal (but not necessarily nominally equal) types. Since we encode the name of the payload type in the name of the constructor function, that made it hard to predict which names would be generated. Now we deduplicate based on the mangled name instead.
dicej
force-pushed
the
future-stream-ctors
branch
from
September 11, 2026 22:10
fea1272 to
c79d7ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would only emit one such constructor function per future or stream "canonical" payload type, where canonicalization would combine structurally equal (but not necessarily nominally equal) types. Since we encode the name of the payload type in the name of the constructor function, that made it hard to predict which names would be generated. Now we deduplicate based on the mangled name instead.