Change to project SDK

[GerardSmit]

PoC to drop runtime.$(NETCoreSdkPortableRuntimeIdentifier).microsoft.dotnet.ilcompiler.llvm in the template.

The new template is as following:

  <Project Sdk="Microsoft.NET.Sdk">
  
+   <Sdk Name="BytecodeAlliance.Componentize.DotNet.Wasm.SDK" Version="[VERSION]">

    <PropertyGroup>
      <OutputType>Exe</OutputType>
      <TargetFramework>net10.0</TargetFramework>
      <RootNamespace>wasi_cli</RootNamespace>
      <ImplicitUsings>enable</ImplicitUsings>
      <Nullable>enable</Nullable>
      <InvariantGlobalization>true</InvariantGlobalization>
    </PropertyGroup>

- <ItemGroup>
-   <PackageReference Include="BytecodeAlliance.Componentize.DotNet.Wasm.SDK" Version="0.7.0-preview*" />
-   <PackageReference Include="runtime.$(NETCoreSdkPortableRuntimeIdentifier).microsoft.dotnet.ilcompiler.llvm" Version="10.0.0-alpha.1.25162.1" />
- </ItemGroup>

  </Project>

Important

This would need a minor bump (to 0.8) since it's a breaking change.

[GerardSmit]

IsImplicitlyDefined is needed because of:

componentize-dotnet/Directory.Packages.props

Lines 2 to 4 in b132a2a

	<PropertyGroup>
	<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
	</PropertyGroup>

Otherwise, it is complaining that the version is not managed by PackageVersion.

[GerardSmit]

I've changed it to <Sdk Name=".." Version=".." /> as 'reflectronic' in Discord mentioned that Aspire does the same:
https://learn.microsoft.com/en-us/dotnet/aspire/fundamentals/dotnet-aspire-sdk#overview

[GerardSmit]

I think there is a typo in property item WitBindgenAddtionalArgs:

componentize-dotnet/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets

Line 95 in b132a2a

<Exec Command="$(WitBindgenExe) c-sharp %(Wit.Identity) %(Wit.WitWorldArg) --runtime $(WitBindgenRuntime) $(WitBindgenAddtionalArgs) --out-dir $(WitGeneratedFilesRoot)" />

Shouldn't this be WitBindgenAdditionalArgs?

[jsturtevant]

This looks like what I was trying to accomplish awhile back! I need to read through https://learn.microsoft.com/en-us/dotnet/core/project-sdk/overview but upon a quick look it seems like this will work.

Are there trade-off of being an SDK version a nuget package? It seems in this case we really are an SDK

[GerardSmit]

The biggest downside that I can find is that NuGet doesn't support updating SDK versions (from NuGet).

When a new version comes out, you have to manually update the version.

See NuGet/Home#13127

I'm not sure if Dependabot supports notifications for new SDK versions.