Add Git commit hash to the revision field of component metadata #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
approved these changes
Mar 24, 2025
Contributor
|
Unfortunately, landing this broke the publish-binaries CI on main, which isnt checked prior to the PR merging... I'll get to fixing that today |
Contributor
Author
|
Ah my bad, it built fine for me on Windows so I assumed it was good |
Contributor
|
Yep it was just a weird thing with cross-compiling for x86_64 from an arm64 mac. Presumably its solvable but it wasnt straightforward through brew, so it was easier to just get rid of the feature. Also, its really on the CI system if it let something land that broke main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets the commit hash from the component package's Git repository, if available, and writes it to the revision field of the component metadata. Resolves issue #378