Cargo.toml: don't accept semver-compatible with parse_arg 0.1.4 #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse_arg 0.1.6 does not build with stable.
sunfishcode
approved these changes
Mar 17, 2025
pchickey
added a commit
that referenced
this pull request
Mar 17, 2025
just a patch release: only change from 0.21.0 is #381 which pins a dep to not use semver
Merged
pchickey
added a commit
that referenced
this pull request
Mar 17, 2025
just a patch release: only change from 0.21.0 is #381 which pins a dep to not use semver
Kixunil
reviewed
Apr 22, 2025
| owo-colors = "4.0.0" | ||
| p256 = "0.13.2" | ||
| parse_arg = "0.1.4" | ||
| parse_arg = "=0.1.4" |
There was a problem hiding this comment.
Hey, this is quite broken solution because it will prevent updates to parse_arg. Projects should generally use Cargo.lock to pin their dependencies.
However, I'm looking into the cause of this issue.
Contributor
Author
There was a problem hiding this comment.
Our users install cargo-component as a binary using cargo install cargo-component so anyone who didnt pass --locked would fail to install. This crate is not intended to be used as a library.
There was a problem hiding this comment.
Well, true, it's cargo's fault that --locked is not default and this kind of pinning does make sense for you now that I understand your usage. Regardless, it's fixed now.
pchickey
added a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_arg 0.1.6 does not build with stable.