Skip to content

IVS-884 - Language Packages Aggregation #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ghesselink wants to merge 2 commits into
base: development
Choose a base branch
from
Open

IVS-884 - Language Packages Aggregation #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f88715
Bump data-model submodule
Ghesselink Aug 26, 2026
817b983
Derive language fields in the model
Ghesselink Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions backend/apps/ifc_validation/fixtures/pass_header_language.ifc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ISO-10303-21;
HEADER;
FILE_DESCRIPTION(('ViewDefinition [ReferenceView_V1.2]', 'ExchangeRequirement [Any]'),'2;1');
FILE_NAME('pass_header_language.ifc','2025-02-13T15:58:45',('jdoe'),('Acme Inc.'),'ABC rel. 0.1.2','Autodesk - Revit 26.4.0.32 (ENU) - 26.4.0.32','IFC4 model');
FILE_SCHEMA(('IFC4'));
ENDSEC;
DATA;
#1=IFCPERSON($,$,'',$,$,$,$);
ENDSEC;
END-ISO-10303-21;
27 changes: 26 additions & 1 deletion backend/apps/ifc_validation/tests/tests_header_validation_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,4 +231,29 @@ def test_header_validation_task_correctly_parses_encoded_company_and_tool(self):
self.assertIsNotNone(model)
self.assertEquals('MyFAB Tool Ä Ä', model.produced_by.name)
self.assertEquals('2026.3', model.produced_by.version)
self.assertEquals('Testä Inc.', model.produced_by.company.name)
self.assertEquals('Testä Inc.', model.produced_by.company.name)
def test_header_validation_task_splits_language_package(self):

# arrange
HeaderValidationTaskTestCase.set_user_context()
request = ValidationRequest.objects.create(
file_name='pass_header_language.ifc',
file='pass_header_language.ifc',
size=1
)
request.mark_as_initiated()

# act
header_validation_subtask(
prev_result={'is_valid': True, 'reason': 'test'},
id=request.id,
file_name=request.file_name
)

# assert
model = Model.objects.get(id=request.id)
self.assertIsNotNone(model)
self.assertEquals('Revit 26.4.0.32 (ENU)', model.produced_by.name)
self.assertEquals('26.4.0.32', model.produced_by.version)
self.assertEquals('Revit 26.4.0.32', model.produced_by.canonical_name)
self.assertEquals('en', model.produced_by.language_code)
Loading