[harmony] Bug 1917423: undo table conversion mess from bug 1898882#154
Open
justdave wants to merge 1 commit into
Open
[harmony] Bug 1917423: undo table conversion mess from bug 1898882#154justdave wants to merge 1 commit into
justdave wants to merge 1 commit into
Conversation
justdave
force-pushed
the
bug1917423-harmony
branch
from
1b69c18 to
8a03ace
Compare
justdave
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR removes the need to store the current database charset in the params file, instead detecting it only at runtime and saving it in memory during the operation of checksetup.pl. The params are instead remapped to the detected value if appropriate.
Additional info
Test Plan