Update deploy_docker.sh

[bugy]

No description provided.

[bugy]

Test results: https://script-server-tests.s3-us-west-2.amazonaws.com/master/750/index.html

[vnghia]

The only thing we need to check is the docker build process, which is only triggered if we create a release :/

[vnghia]

Ah no, so the problem is deeper than I thought. Since the Docker image is just copying the process, which is specific for amd64. I will investigate and return back to you later

[bugy]

Sorry, which process are you talking about?

[vnghia]

I guess the right thing to do is having a standalone Dockerfile as in #206. We can use the multi-stage build technique to keep the image size as small as possible (probably approximately equal to the current one) so your concern in this #206 (comment) is solved

[vnghia]

Sorry, which process are you talking about?

Sorry, I mean the output of the CI process, the build/script-server.zip

[bugy]

But the zip file should contain only python files, which are supposed to be platform independent

[vnghia]

I missed that part. Could you trigger the docker build ?

[bugy]

Test results: https://script-server-tests.s3-us-west-2.amazonaws.com/master/752/index.html

[bugy]

I'm trying to make docker image work for PRs

[bugy]

@vnghia there is an error:

unknown flag: --platform

[bugy]

https://app.travis-ci.com/github/bugy/script-server/builds/267081647

[vnghia]

Is there a way I can test it on my PR ?

[bugy]

can you try pushing any changes from your PR? I made a change to travis, probably it should build your PR now

[vnghia]

Still not running, but adding three lines here is good I think: https://github.com/bugy/script-server/pull/715/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485

[vnghia]

Can you show me the log :/

[bugy]

https://app.travis-ci.com/github/bugy/script-server/builds/267081647

don't you have access to this section?

[bugy]

btw, I gave you access to this repo, you can try doing changes in my branch

[vnghia]

I see the log now, Travis blocked me while I am on VPN :/

[vnghia]

hmm it seems that the CI won't run if there are my trace in the PR, maybe because I am a new contributor and it won't run unless you have to approve the PR once ?

[bugy]

@vnghia I triggered the build manually and it worked! Could you try running arm docker container, please?
https://hub.docker.com/repository/docker/bugy/script-server/tags?page=1&ordering=last_updated

[vnghia]

It's working! Actually, you can test it on your own computer with docker run --rm -it --platform linux/arm64 -p 5000:5000 bugy/script-server:test-amd-build assuming that you have qemu installed.

[bugy]

Cool, thanks! Could you apply the same changes to your PR please? And then we merge it

[vnghia]

Done !