Conversation
Remove the no-op on_receive_notification handler from spawn_subagent_inner (crates/zeph-acp/src/client/mod.rs). The handler was intercepting all session/update messages at the connection level and discarding them, so agent_message_chunk notifications never reached update_rx. drain_until_stop now receives text chunks correctly, fixing the empty-output regression in `zeph acp run-agent` (#3520). Box agent.run() at the two affected call sites (src/acp.rs:901, crates/zeph-bench/src/runner.rs:532) to move the 17 400-byte future onto the heap and resolve the clippy::large_futures error that appeared when building with --features full (classifiers) (#3521). Closes #3520 Closes #3521
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_receive_notificationhandler fromspawn_subagent_innerincrates/zeph-acp/src/client/mod.rs. The handler was intercepting allsession/updatemessages at the connection level and discarding them beforeActiveSessionHandlercould route them intoupdate_rx. As a result,drain_until_stopnever received text chunks andzeph acp run-agentalways produced empty stdout.agent.run()at two call sites (src/acp.rs:901,crates/zeph-bench/src/runner.rs:532) to move the 17 400-byte future onto the heap, eliminating theclippy::large_futureserror triggered when building with--features full(includesclassifiers).Test plan
cargo build --features full— compiles without errorscargo clippy --workspace --features full -- -D warnings— zero warnings/errors (large_futures gone)cargo +nightly fmt --check— no formatting issuescargo nextest run --config-file .github/nextest.toml --workspace --lib --bins— 8653 tests passCloses #3520
Closes #3521