Open
Conversation
This PR fixes a couple more conformance issues found through the broader
test suite:
- A bug in `fdp` where comments attribution should be checking for
`R{Paren,Bracket,Brace}` rather than `L{Paren,Bracket,Brace}`
- `proto3_optional` should be set on a field for explicit presence
- A small bug in `ir_test.go` where the source code info location should
set trailing comments
- We fixed allowing prefixed group fields in the lexer, but we also need
to handle the prefix in the lowering step for prefixed group fields
- Fix a `TODO` to resolve group fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple more conformance issues found through the broader test suite:
fdpwhere comments attribution should be checking forR{Paren,Bracket,Brace}rather thanL{Paren,Bracket,Brace}fdpwhere the wrong tag was used for message extensionsproto3_optionalshould be set on a field for explicit presenceir_test.gowhere the source code info location should set trailing commentsTODOto resolve group fields