Bump protocolbuffers/kotlin v34.1 kotlin compiler version#2366
Merged
stefanvanburen merged 3 commits intomainfrom Mar 31, 2026
Merged
Bump protocolbuffers/kotlin v34.1 kotlin compiler version#2366stefanvanburen merged 3 commits intomainfrom
stefanvanburen merged 3 commits intomainfrom
Conversation
Seems like this was maybe bumped here: protocolbuffers/protobuf@763c5da#diff-6136fc12446089c3db7360e923203dd114b6a1466252e71667c6791c20fe6bdcR38 Failing to compile upstream. Similar to c3b930c.
pkwarren
reviewed
Mar 31, 2026
| compiler: | ||
| kotlin: | ||
| version: 1.8.22 | ||
| api_version: "1.8" |
Member
There was a problem hiding this comment.
Might as well bump this to 2.1 to match connect-kotlin while we're here. I don't recall but I think 1.8 may have been removed or at least deprecated in this version of the kotlin compiler.
We're also going to need to update the pom.xml file too.
pkwarren
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like this was maybe bumped here:
protocolbuffers/protobuf@763c5da#diff-6136fc12446089c3db7360e923203dd114b6a1466252e71667c6791c20fe6bdcR38
Failing to compile upstream.
Similar to c3b930c.