Skip to content

Fix buf convert panic without syntax or unused imports - #4732

Merged
emcfarlane merged 4 commits into
mainfrom
ed/fixPanic
Oct 13, 2026
Merged

emcfarlane merged 4 commits into
mainfrom
ed/fixPanic

Conversation

@emcfarlane

Copy link
Copy Markdown
Contributor

This fixes a panic when converting images. Occurs when the image doesn't have a syntax declaration or has unused imports. The fallback resolver used during building provides the types required (if not present) but a loaded image from a .binpb doesn't have these. This difference causes the nil exception.

Related to #4602.

Closes #4731.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 13, 2026, 2:50 PM

@emcfarlane
emcfarlane requested a review from doriable October 13, 2026 16:15
@emcfarlane
emcfarlane merged commit 2d84f23 into main Oct 13, 2026
10 checks passed
@emcfarlane
emcfarlane deleted the ed/fixPanic branch October 13, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buf convert panics with some inputs

2 participants