Fix buf dep graph --format json silently dropping dependencies#4419
Merged
emcfarlane merged 2 commits intobufbuild:mainfrom Mar 31, 2026
Merged
Fix buf dep graph --format json silently dropping dependencies#4419emcfarlane merged 2 commits intobufbuild:mainfrom
emcfarlane merged 2 commits intobufbuild:mainfrom
Conversation
The addDeps method had a `return nil` that exited the entire loop after encountering the first already-seen dependency, causing all subsequent dependencies to be silently dropped from the JSON output. Changed to `continue` so the loop processes all dependencies. Adds a regression test with a three-module workspace (alpha, common, zeta) where zeta depends on both alpha and common. Because modules are walked alphabetically, both of zeta's deps are already in the seen map when zeta is processed, which triggered the early return. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
emcfarlane
approved these changes
Mar 30, 2026
Contributor
emcfarlane
left a comment
emcfarlane
left a comment
There was a problem hiding this comment.
Thanks for the fix! Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addDeps method had a
return nilthat exited the entire loop after encountering the first already-seen dependency, causing all subsequent dependencies to be silently dropped from the JSON output. Changed tocontinueso the loop processes all dependencies.Adds a regression test with a three-module workspace (alpha, common, zeta) where zeta depends on both alpha and common. Because modules are walked alphabetically, both of zeta's deps are already in the seen map when zeta is processed, which triggered the early return.