Skip to content

fix(snowflake): add type assertion for SQL API response #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhubzy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(snowflake): add type assertion for SQL API response #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96da0e4
fix(snowflake): add type assertion for SQL API response to fix TS1804…
zhubzy Mar 27, 2026
2146afc
Merge remote-tracking branch 'origin/main' into zhubzy/fix-typecheck-…
zhubzy Mar 27, 2026
0e08e4e
fix(shared-schemas): add missing FLAGSHIP legacy alias to RECOMMENDED…
zhubzy Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/bubble-core/src/bubbles/service-bubble/snowflake/snowflake.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,14 @@ export class SnowflakeBubble<
);
}

const result = await response.json();
const result = (await response.json()) as {
resultSetMetaData?: {
numRows: number;
rowType: { name: string; type: string; nullable: boolean }[];
};
data?: (string | null)[][];
statementHandle?: string;
};
Comment on lines +195 to +202
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Snowflake SQL API response shape is now duplicated inline as an anonymous type assertion. To reduce drift (especially since executeStatement already has an explicit return type), consider extracting a named type (e.g., SnowflakeStatementResponse) and reusing it here and in the function signature.

Copilot uses AI. Check for mistakes.

// Handle async execution (202 status)
if (response.status === 202) {
Expand Down
1 change: 1 addition & 0 deletions packages/bubble-shared-schemas/src/ai-models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const RECOMMENDED_MODELS = {
// Legacy aliases (unchanged behavior)
BEST: 'google/gemini-3-pro-preview',
BEST_ALT: 'openai/gpt-5.2',
FLAGSHIP: 'google/gemini-3-flash-preview',
PRO: 'google/gemini-3-flash-preview',
PRO_ALT: 'anthropic/claude-sonnet-4-5',
FAST: 'google/gemini-2.5-flash-lite',
Expand Down
Loading