Repository navigation
Conversation
fetchAccessibilityIssues only handed the agent the account's false-positive memory and left it to apply the entries; startAccessibilityScan did not read the memory at all, so a scan's first answer listed and counted issues the account had already marked as not real. Both now leave out, server side, the issues an entry names by its pattern's tag, tags, tagPrefix or classes (within its site and scope), and say how many each entry left out. The rest of the memory still comes with the issues for the agent to apply with judgment. - report-parser: a leaveOut hook drops covered issues from every page and count (summary, duplicates, per-page counts) while keeping the order, rule texts and cursor offsets of the full report, so held cursors stay valid. - paginate: pageOf takes a skip predicate that still advances the cursor. - fp-memory: applyMemory matches entries by pattern fields, never prose; counter-examples, excludeTags and tags a predicate excludes are kept. - accessibility: shared memoryLeaveOut helper used by both fetchAccessibilityIssues and startAccessibilityScan. - web_accessibility capability index: pattern.tags and pattern.excludeTags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #554. Merge that first; this PR then retargets to
main.Problem
#554 only adds the account's false-positive memory to
fetchAccessibilityIssuesanswers and leaves the agent to apply the entries.startAccessibilityScannever reads the memory. So a scan's first answer lists and counts issues the account has already marked as not real, and says nothing about the memory. The agent has no reason to fetch again.Seen on
https://www.sbb.ch/de/angebote/halbtax(scan 4311473, run 2431733):startAccessibilityScanfetchAccessibilityIssues(same run)Change
Both tools now drop, on the server, any issue that a saved entry names by its pattern's
tag,tags,tagPrefixorclasses, within the entry's site and scope. The answer says how many issues each entry left out. The remaining entries for the page's rules still come with the issues, for the agent to apply with judgment.report-parser: newleaveOuthook. Covered issues are dropped from every page and from every count (summary, duplicates, per-page counts). The full report's order, rule texts and cursor offsets are kept, so a cursor the agent already holds stays valid.paginate:pageOftakes askippredicate. Skipped rows still move the cursor forward.fp-memory:applyMemorymatches entries on pattern fields, never on the predicate's wording. Counter-examples,excludeTags, and tags the predicate's own wording excludes (e.g. "Does not cover sbb-breadcrumb") are never dropped.accessibility: new sharedmemoryLeaveOuthelper, used by bothfetchAccessibilityIssuesandstartAccessibilityScan.web_accessibilitycapability index: addspattern.tagsandpattern.excludeTags, and explains that filtering uses pattern fields only.Not in this PR
fetchAccessibilityIssueswithcompareWith(compareScanRuns) still doesn't apply the memory, so saved false positives can still show up as new issues.startAccessibilityScanwith a memory. The new tests cover the fetch path, the parser and the matcher.Testing
tsc --noEmitpasses, and all 140 test files (2,070 tests) pass under Node 22.sbb-breadcrumb, which the entries exclude.startAccessibilityScanpath.🤖 Generated with Claude Code