Skip to content

fix(accessibility): don't hold calls on finalizing reports; say when a run failed or the plan refuses #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aaryan430 wants to merge 1 commit into from
Closed

fix(accessibility): don't hold calls on finalizing reports; say when a run failed or the plan refuses #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/lib/feedback-hint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,18 @@ export const NO_HINT_TOOLS: ReadonlySet<string> = new Set([
"getAccessibilityAuthConfig",
]);

/**
* Set (as a symbol-keyed property, so it is never serialised to the client) on an error
* result that the user resolves on their own account, such as a plan limit. Asking the
* agent to report those with submitFeedback only sends it the wrong way.
*/
export const NO_FEEDBACK_HINT = Symbol.for("browserstack.mcp.noFeedbackHint");

export function withFeedbackHint<T>(toolName: string, result: T): T {
if (NO_HINT_TOOLS.has(toolName)) return result;
const r = result as { isError?: unknown; content?: unknown } | null;
if (typeof r !== "object" || r === null || r.isError !== true) return result;
if ((r as Record<symbol, unknown>)[NO_FEEDBACK_HINT] === true) return result;
if (!Array.isArray(r.content) || SELF_FIXABLE.test(textOf(r))) return result;
return {
...r,
Expand Down
Loading