remove default temp#2076
Open
filip-michalsky wants to merge 1 commit intomainfrom
Open
Conversation
|
Contributor
There was a problem hiding this comment.
No issues found across 5 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant User as Caller / SDK User
participant Inf as Inference Logic (act/extract/observe)
participant Client as LLMClient (Base Interface)
participant Provider as Groq/Cerebras Client
participant API as External LLM Provider
Note over User,Inf: Request starts (e.g. stagehand.act)
User->>Inf: call(instruction, options)
Inf->>Inf: Build System/User Prompts
Note over Inf: CHANGED: Removed default temperature logic<br/>(Previously forced 0.1 or 1.0 for GPT-5)
Inf->>Client: createChatCompletion(request)
Client->>Provider: createChatCompletion(request)
alt NEW: Explicit Temperature Provided
Provider->>Provider: Map temperature from options
else NEW: Temperature is Undefined
Note over Provider: CHANGED: No longer defaults to 0.7<br/>Allows Provider API to use its own default
Provider->>Provider: temperature = undefined
end
Provider->>API: POST /chat/completions (JSON Payload)
Note right of API: Payload includes temperature ONLY if provided
API-->>Provider: ChatCompletion Response
Provider-->>Inf: Structured Data / Action
Inf-->>User: Final Result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
Stagehand v3 was setting hard-coded temperature defaults for standard act, extract, and observe inference calls. This forced provider
behavior instead of letting model/provider defaults apply.
what changed
Removed the hard-coded temperature: isGPT5 ? 1 : 0.1 defaults from shared act, extract, and observe inference.
Removed the unused GPT-5 temperature branching in that path.
Updated Groq and Cerebras clients to pass through options.temperature directly instead of defaulting missing values to 0.7, while preserving
explicit temperature: 0.
Added regression tests covering:
test plan
unit/inference-temperature.test.ts tests/unit/openai-compatible-temperature.test.ts
dist/esm/tests/unit/openai-compatible-temperature.test.js packages/core/dist/esm/tests/unit/aisdk-clients.test.js packages/core/dist/esm/
tests/unit/anthropic-cua-adaptive-thinking.test.js