-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(core): infer Google CUA screenshot MIME type from data URLs #2048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BABTUNA
wants to merge
1
commit into
browserbase:main
Choose a base branch
from
BABTUNA:fix-google-cua-mime-inference
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+118
−7
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { GoogleCUAClient } from "../../lib/v3/agent/GoogleCUAClient.js"; | ||
|
|
||
| type ParseScreenshotDataUrlFn = (screenshot: string) => { | ||
| mimeType: string; | ||
| base64Data: string; | ||
| }; | ||
|
|
||
| const parseScreenshotDataUrl = ( | ||
| GoogleCUAClient.prototype as unknown as { | ||
| parseScreenshotDataUrl: ParseScreenshotDataUrlFn; | ||
| } | ||
| ).parseScreenshotDataUrl; | ||
|
|
||
| function createClient(): GoogleCUAClient { | ||
| return new GoogleCUAClient( | ||
| "google", | ||
| "google/gemini-2.5-computer-use-preview-10-2025", | ||
| "test instructions", | ||
| { apiKey: "test" }, | ||
| ); | ||
| } | ||
|
|
||
| describe("GoogleCUAClient screenshot MIME handling", () => { | ||
| it("preserves image data URLs passed via captureScreenshot options", async () => { | ||
| const client = createClient(); | ||
| const jpegDataUrl = "data:image/jpeg;base64,abc123"; | ||
|
|
||
| const screenshot = await client.captureScreenshot({ | ||
| base64Image: jpegDataUrl, | ||
| }); | ||
|
|
||
| expect(screenshot).toBe(jpegDataUrl); | ||
| }); | ||
|
|
||
| it("defaults raw base64 captureScreenshot options to PNG data URL", async () => { | ||
| const client = createClient(); | ||
|
|
||
| const screenshot = await client.captureScreenshot({ | ||
| base64Image: "abc123", | ||
| }); | ||
|
|
||
| expect(screenshot).toBe("data:image/png;base64,abc123"); | ||
| }); | ||
|
|
||
| it("extracts JPEG mime type and base64 payload from data URLs", () => { | ||
| const client = createClient(); | ||
|
|
||
| const parsed = parseScreenshotDataUrl.call( | ||
| client, | ||
| "data:image/jpg;base64,abc123", | ||
| ); | ||
|
|
||
| expect(parsed).toEqual({ | ||
| mimeType: "image/jpeg", | ||
| base64Data: "abc123", | ||
| }); | ||
| }); | ||
|
|
||
| it("falls back to PNG mime type for non-image data URLs", () => { | ||
| const client = createClient(); | ||
|
|
||
| const parsed = parseScreenshotDataUrl.call( | ||
| client, | ||
| "data:application/octet-stream;base64,abc123", | ||
| ); | ||
|
|
||
| expect(parsed).toEqual({ | ||
| mimeType: "image/png", | ||
| base64Data: "abc123", | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Data URL parsing is too strict and can corrupt valid parameterized base64 data URLs, producing malformed screenshot payloads.
Prompt for AI agents