Skip to content

move Android package ID from build.gradle to package.json#153

Closed
brody4hire wants to merge 7 commits intomasterfrom
with-native-section
Closed

move Android package ID from build.gradle to package.json#153
brody4hire wants to merge 7 commits intomasterfrom
with-native-section

Conversation

@brody4hire
Copy link
Owner

@brody4hire brody4hire commented Sep 22, 2019 •
edited
Loading

(updated)

in order to make the android/build.gradle artifact 100% generic

i.e. rendered directly from the template, with zero module-specific customization

resolves the following TODO item in #19:

fix generated android/build.gradle to read and use the packageIdentifier value from package.json, in order to make this Android build artifact zero percent customized

todo:

  • test with generated example on most recent React Native version (0.62 at the time of this update)
  • test with generated example on an older React Native version such as 0.61 or 0.60

@brody4hire brody4hire self-assigned this Sep 22, 2019
@brody4hire brody4hire force-pushed the with-native-section branch 2 times, most recently from 7ff4e44 to 7e8cb06 Compare September 22, 2019 20:18
@brody4hire brody4hire marked this pull request as ready for review September 22, 2019 20:20
@brody4hire brody4hire mentioned this pull request Sep 22, 2019
Draft
4 tasks
@brody4hire brody4hire changed the base branch from dev to master November 15, 2019 05:38
Christopher J. Brody added 3 commits April 2, 2020 11:12
add native item with package ID to package.json
662bb75 
in order to make the `android/build.gradle` artifact 100% generic

i.e. rendered directly from the template,
with zero module-specific customization
make it android item with the packageIdentifier field in `package…
4b320e9 
….json`
update test snapshots
16bfdcc
@brody4hire brody4hire force-pushed the with-native-section branch from 5865529 to 16bfdcc Compare April 2, 2020 15:16
@brody4hire brody4hire changed the title add native item with package ID to package.json add native item with Android package ID to package.json Apr 2, 2020
@brody4hire brody4hire changed the title add native item with Android package ID to package.json [WIP] add native item with Android package ID to package.json Apr 2, 2020
@brody4hire brody4hire marked this pull request as draft July 12, 2020 22:48
@brody4hire brody4hire changed the title [WIP] add native item with Android package ID to package.json configure native Android package ID item in package.json Aug 13, 2020
@brody4hire brody4hire changed the title configure native Android package ID item in package.json move native Android package ID item into package.json Aug 13, 2020
@brody4hire brody4hire mentioned this pull request Aug 14, 2020
Closed
@brody4hire brody4hire changed the title move native Android package ID item into package.json move Android package ID from build.gradle to package.json Feb 10, 2021
@brody4hire
Copy link
Owner Author

brody4hire commented Feb 10, 2021

I am not planning to merge this. From PR #403 we can see that the Android package ID will not be needed in build.gradle by default.

@brody4hire brody4hire closed this Feb 10, 2021
@brody4hire brody4hire deleted the with-native-section branch February 10, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brody4hire brody4hire

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@brody4hire