feat(dsl): Add RGBDocument, generator video clip DTD support, and timeline packing - #31
feat(dsl): Add RGBDocument, generator video clip DTD support, and timeline packing#31leogdion wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| } | ||
|
|
||
| /// A DSL clip node whose duration can be set or updated via `.duration(...)`. | ||
| public protocol DSLNodeWithDuration: DocumentContent { |
There was a problem hiding this comment.
what is a DSLNode without duration? In SwiftUI if it doesn't support the function then it just returns it unmodified.
…lors Replace DSLNodeWithDuration with a SwiftUI-style duration modifier on DocumentContent, and match FCP Color Solid exports that use four-component color strings so ColorTests and generator export stay aligned. Co-authored-by: Cursor <cursoragent@cursor.com>
Split Color platform bridges and FCPTime interval helpers, convert TitlePreset/TransitionPreset to GeneratorPreset-style structs with a text-only Title init, and document the convention in a Cursor rule. Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
Summary
RGBDocumentinSources/fcpxml-dsl/RGBDocument.swiftandfcpxml-dsl export rgbCLI command.<video ref="...">elements inSpine, matching FCPXML 1.13/1.14 DTD rules..videoand.generatorpacking handlers inLayout.packfor sequential timeline offsets and centered transition overlaps.9999/10008/10006/2/1/1) and 3-component RGB strings (value="1 0 0").fcpxml-diff validateand live AppleScript FCP import (verify-import).