Conversation
zoya-brd
marked this pull request as ready for review
September 15, 2026 05:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
brightdata login --githubfailed with "No Bright Dataaccount found for your GitHub email" when the GitHub identity had no
matching Bright Data account. Remove that user_not_found hard-fail so a
brand-new identity flows through the existing init->gist->verify pipeline,
is created server-side via find-or-create, and has its minted key saved
like any successful login.
The exit-code contract is unchanged and still enforced: ensure_api_key
guarantees the flow only returns with a real key, so the CLI exits 0
only when an account was created or matched and a key was received; any
verification failure throws and exits non-zero.
Update tests to assert the new behavior: a missing account no longer
dead-ends, and an init error surfaces as a generic non-zero failure.