Skip to content

fix(pg-pool): wait for clients to close during shutdown - #3865

Open
Toufiqul-27 wants to merge 1 commit into
brianc:masterfrom
Toufiqul-27:fix/await-pool-client-close
Open

Toufiqul-27 wants to merge 1 commit into
brianc:masterfrom
Toufiqul-27:fix/await-pool-client-close

Conversation

@Toufiqul-27

Copy link
Copy Markdown

For #3287 and the next major release discussion.

Make pool.end() wait until all client close callbacks complete. Two regression tests cover idle and checked-out clients. Both fail before the fix and pass after it.

Four targeted tests and formatting passed. The PostgreSQL integration suite was not run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant