Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date parameters lose part of their offset when the local timezone used second-level offsets. With
TZ=Africa/Monrovia,new Date(0)becomes1969-12-31T23:15:30.000-00:44, which PostgreSQL reads as -30,000ms instead of 0.Keep the local date/time fields and append the offset's seconds when present. This covers Date arrays too; the UTC serialization option stays unchanged.
Added unit cases for positive and negative historical offsets, UTC, BC years and input preservation. The PostgreSQL tests exercise both JS and native clients with ISO-string controls and Date arrays, and check the local fields for
timestampanddate.Checked on Linux arm64, Node 24.21.0 and PostgreSQL 15.19:
yarn lintandyarn testpass.The harness skipped pg-worker, SCRAM, two native-pipeline cases and PostgreSQL 17+ direct SSL. pg-pool reports one pending test. Other CI versions and platforms were not run locally.
Prepared with AI assistance.