-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: upgrade to nextra v3 #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6b54f33 to
27e0309
Compare
| "scripts": { | ||
| "start": "next dev", | ||
| "build": "next build && next export" | ||
| "dev": "next dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README.md for docs has instructions to run the dev command, so I moved next dev to use that command instead of start.
charmander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the caveat that I haven’t reviewed the 470 dependencies used in 20 static pages of documentation, and hope anyone attempting to render the docs is doing so in a suitable sandbox.
Thank you for fixing this longstanding bug!
|
Dang thanks for doing this! I'll review, test, and deploy if it all looks good. :) |
|
Tried running the docs locally: Doesn't work. Any tips would be appreciated here if you have time to look 👀 @McAllaster I know it's been a long time. Sorry for the delay. Got a pretty intense job for a while I've now left. |
Additionally, remove non-working `start` command from docs `package.json`, as it was replaced by `dev` for consistency with the `README.md` in that directory.
Looks like I forgot to update the top-level Removed the non-working script as well to (hopefully) avoid confusion. |
|
ah thanks - i'll take a look again today 🙌 |
This pull request updates
nextrato version 3 (following the migration guide), and updates its dependencies.Nextra had an odd issue with font rendering using the
ss06font feature settings on fonts which support it, causing issues with capital letters (see image below). It has since been resolved.I am sure there are other changes that v3 introduced, but I did not notice any regressions in the documentation.
Note that v4 of
nextrais available, but being fairly unfamiliar with it, I opted to only upgrade a single major version.