Open
Conversation
mnapoli
reviewed
Mar 7, 2026
| ARG OL_VERSION=8 | ||
| ARG IC_VERSION=21 | ||
| # Oracle Instant Client image | ||
| FROM public.ecr.aws/docker/library/oraclelinux:$OL_VERSION AS oracle_base |
Member
There was a problem hiding this comment.
Have you tested the layer? Here the library is installed in an image that is not the one used in AWS Lambda, there's high risk the library is incompatible when running in Lambda.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the OCI8 layer for version 3. A lot of this is thanks to the work of @alraben and the previous maintainer's version. It is currently only compatible with PHP 8.3+.
It has been tested against a live app using
arn:aws:lambda:us-west-2:873528684822:layer:php-84:16as the base layer. Hopefully there aren't any sneaky dependency issues that I missed.