Update Fork to master from 2024-4-9 #175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monthly update for August 21
New notifier: Google Chat
* library update to support params/templating Co-authored-by: Aric Zhuang <aricz@google.com>
* add bindings/templating to the Slack Notifier
* add bindings/templating to the smtp-notifier
After #134 [1] the slack message stopped having the vertical bar on the left, which gave the message some context depending on the build status. Passing an attachment block with color, has no effect to the sibling blocks. To give blocks the proper color context, we need to move them inside the attachments [2]. This must be done with having in mind that, according to Slack's documentation [3] secondary attachments are deprecated. However, there is no other way of giving color context to a block message [4]. [1] GoogleCloudPlatform#134 [2] https://api.slack.com/reference/messaging/attachments [3] https://api.slack.com/messaging/composing/layouts#attachments [4] https://api.slack.com/messaging/attachments-to-blocks#direct_equivalents
Slack provides the ability to color the vertical bar when creating an attachment with blocks. According to the documentation, it also provides predefined colors [1]. However, the predefined colors see to work only with the legacy [2] fields [2] and not with blocks. I have not found anything in the documentation related to this but can be easily verified using the kit builder [3]. I have two examples, one with an attachment block [4] and one with an attachment text [5] that verify this. [1] https://api.slack.com/reference/messaging/attachments#fields [2] https://api.slack.com/reference/messaging/attachments#legacy_fields [3] https://app.slack.com/block-kit-builder [4] https://t.ly/ljPu [5] https://t.ly/ub-R
* add bindings/templating to the bq notifier
* add bindings/templating to http notifier
* new notifier - github issues
update slack example
* prevent invalid pubsub subscription names
PR #131 added validation of config paths. Unfortunately, the validation was incorrect. The regex from the PR: `^gs://([[\w-]+)/([^\\]+$)` This allows the bucket name to be word characters and `-`. I.e. `config-42-example-com`. In reality `_` and `.` is also allowed! (see https://cloud.google.com/storage/docs/buckets#naming) Our company prefers DNS style buckets, i.e., `config.example.com`, so this change just broke our use of the build-notifiers
add new line for test PR using the newly setup PR trigger
slack: Add block color context
Fix validation of GCS bucket names
This change attempts to update all third-party dependencies to their latest versions in an attempt to resolve import issues resulting from the collision of the [genproto migration](https://code.googlesource.com/gocloud/+/refs/heads/main/migration.md) and importing Go repositories in a Bazel workspace. This was done by running: ``` go get -u ./... go run cloud.google.com/go/internal/aliasfix/cmd/aliasfix@latest . go mod tidy ``` Tested: * `go build ./...` still works * `go test ./...` still passes
Minor fixes update deps
…llowrepl Allow replace function in template validation
chore: bumping go/cloudbuild to have updated enums
Updating the /go/cloudbuild version to include new enum types
…milyyfchen-monthly-update Monthly update for November 23
Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…ependabot/go_modules/samples/logging-sample/google.golang.org/protobuf-1.33.0 Bump google.golang.org/protobuf from 1.30.0 to 1.33.0 in /samples/logging-sample
…ependabot/go_modules/google.golang.org/protobuf-1.33.0 Bump google.golang.org/protobuf from 1.30.0 to 1.33.0
…-monthly-update Monthly update for 04-2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Fork to master from 2024-4-9