chore(deps): bump com.puppycrawl.tools:checkstyle from 10.23.1 to 13.4.0

[dependabot]

Bumps com.puppycrawl.tools:checkstyle from 10.23.1 to 13.4.0.

Release notes

Sourced from com.puppycrawl.tools:checkstyle's releases.

checkstyle-13.4.0

Checkstyle 13.4.0 - https://checkstyle.org/releasenotes.html#Release_13.4.0

Breaking backward compatibility:

#8315 - Improve violation message of ImportOrder

New:

#17565 - Line break must be present after { of non-empty block in switch rule #18065 - New Check: IllegalSymbol to forbit emoj in code

Bug fixes:

#18228 - False-positive: Suppress indentation check when quotes start at the left margin #17137 - UnnecessaryNullCheckWithInstanceOf ignores redundant null check for complex cases. #17842 - False-negative: Member names with underscores

... (truncated)

Commits

• ad2d2d2 [maven-release-plugin] prepare release checkstyle-13.4.0
• ac969f5 doc: release notes for 13.4.0
• b96d1c3 Issue #15456: Define violation messages for JavadocTagContinuationIndentation
• d47cde5 Issue #11163: Enforce file size on InputNeedBracesTestSwitchExpression
• bbb00f9 Issue #16361: add comment on testAddException
• 601213d Issue #12721: add Buildkite CI with mvn verify
• 95cecf8 dependency: bump org.openrewrite.recipe:rewrite-migrate-java
• 92dcd3d dependency: bump pmd.version from 7.22.0 to 7.23.0
• ab7a33c Issue #16361: Refactor testNewCtor
• 70cab66 Issue #16361: Add explanatory comment for testReadResourceWithInvalidName
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[bramp]

@copilot please make the appropriate changes to upgrade to the latest version of check style. The API of this library should not change, so I suspect we should disable some checks

[Copilot]

@copilot please make the appropriate changes to upgrade to the latest version of check style. The API of this library should not change, so I suspect we should disable some checks

Done in commit 2f88d63. Here's what was needed:

Checkstyle 13.x requires Java 21, so the plugin execution was moved from the Java 17+ Maven profile to Java 21+ — this ensures mvn verify on JDK 11/17 no longer tries (and fails) to load checkstyle 13.x.

Three new checks needed handling:

• TodoComment — Fixed all 40+ // TODO text comments across src/main/ to use the required colon format (// TODO: text). Suppression removed.
• GoogleNonConstantFieldName — Renamed all private/package-private snake_case fields to camelCase (subtitle_codec → subtitleCodec, pass_directory → passDirectory, last_pts → lastPts, etc.). Only suppressed for directories with public snake_case fields that mirror FFmpeg's JSON API (probe/, builder/, options/, progress/).
• SummaryJavadoc — Suppressed only for builder/, where codec names like aptX and iCEDraw are proper nouns that legitimately begin with lowercase.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• central.sonatype.com
  • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/ffmpeg-cli-wrapper/ffmpeg-cli-wrapper org.codehaus.plexus.classworlds.launcher.Launcher --batch-mode compile -Dmaven.compiler.failOnError=true -c git status --porcelain --ignore-submodules | head -n 10 \1|g wrapper/src/main/java/net/bramp/ffmpeg/job/SinglePassFFmpegJob.java --global credential.usern-i /home/REDACTED/.lo-E /home/REDACTED/wors|// TODO$|// TODO:|g; s|// TODO ([^:])|// TODO: \1|g (dns block)
  • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/ffmpeg-cli-wrapper/ffmpeg-cli-wrapper org.codehaus.plexus.classworlds.launcher.Launcher --batch-mode compile -Dmaven.compiler.failOnError=true -P !java21 \1|g /java/net/bramp/ffmpeg/progress/StreamProgressParser.java get --global (dns block)
  • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/ffmpeg-cli-wrapper/ffmpeg-cli-wrapper org.codehaus.plexus.classworlds.launcher.Launcher --batch-mode compile -Dmaven.compiler.failOnError=true add . \1|g wrapper/src/main/java/net/bramp/ffmpeg/info/StandardChannelLayout.java --local --get tnet/tools/bash bash (dns block)
• checkstyle.org
  • Triggering command: /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/xml/tools/xml-extractor.jar --fileList=/tmp/codeql-scratch-cbeacfe9e26ce20e/dbs/java/working/files-to-index12342561519375235468.list --sourceArchiveDir=/tmp/codeql-scratch-cbeacfe9e26ce20e/dbs/java/src --outputDir=/tmp/codeql-scratch-cbeacfe9e26ce20e/dbs/java/trap/java ([^:])|// TODO: \1|g pper/ffmpeg-cli-wrapper/src/main/java/net/bramp/ffmpeg/info/StandardChannelLayout.java --noprofile (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)