Skip to content

refactor(nox): table-drive provider sessions - #907

Merged
Abhijeet Prasad (AbhiPrasad) merged 3 commits into
mainfrom
abhi/codex/issue-900-pr7-table-driven-sessions
Oct 9, 2026
Merged

Abhijeet Prasad (AbhiPrasad) merged 3 commits into
mainfrom
abhi/codex/issue-900-pr7-table-driven-sessions

Conversation

@AbhiPrasad

@AbhiPrasad Abhijeet Prasad (AbhiPrasad) commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

resolves #900

Summary

  • Register routine provider nox sessions from compact declarative specs while preserving session IDs and version matrices.
  • Share Python and OS compatibility constraints between nox and the shard planner, filtering sessions that will skip on the target CI job.
  • Pass the CI Python and OS matrix values to the shard planner.

Validation

  • Focused matrix tests passed before the test file was removed at the user's request.
  • Ruff checks and repository pre-commit hooks passed.
  • retained existing session IDs; Python/OS shard dry runs showed filtering.
  • passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T18:22:22.533123Z 752913e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85553485ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread py/nox_session_constraints.py Outdated
CONSTRAINTS = {
"test_ai_sdk": {"min_python": "3.12"},
"test_litellm": {"versions": {"latest": {"min_python": "3.11"}}},
"test_livekit_agents": {"max_python_exclusive": "3.14", "platforms": ["linux"]},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve LiveKit runs when the server is installed

On Windows or macOS hosts where livekit-server is installed on PATH, this platform constraint makes _skip_if_incompatible() exit before _ensure_livekit_server() can use the executable. That function intentionally checks PATH before applying its non-Linux fallback and explicitly directs local users to install the server, so the new shared constraint removes previously supported local integration coverage; apply the Linux-only restriction only in CI sharding or retain the existing PATH-aware behavior.

AGENTS.md reference: AGENTS.md:L136-L141

Useful? React with 👍 / 👎.

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit fa5f160 into main Oct 9, 2026
83 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi/codex/issue-900-pr7-table-driven-sessions branch October 9, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve noxfile: install consistency, reproducibility, and CI time

1 participant