Skip to content

Fix eval parameters omit null description#613

Open
Pedro Mora (stretpjc) wants to merge 2 commits into
mainfrom
fix-eval-parameters-omit-null-description
Open

Fix eval parameters omit null description#613
Pedro Mora (stretpjc) wants to merge 2 commits into
mainfrom
fix-eval-parameters-omit-null-description

Conversation

@stretpjc

Copy link
Copy Markdown

Summary

Remote eval dev mode (braintrust eval <file> --dev) hid all evals in the playground UI when any eval declared a parameter without a description.

All three branches of serialize_eval_parameters (prompt, model, data) emitted "description": null when unset. The playground's zod schema only accepts a string or an absent key, and it validates the whole /list response in one
safeParse — so one description-less parameter hid every eval on the endpoint.

Fix: include description only when it's not None, same as default already is. #508 fixed this pattern for prompt defaults; description was missed.

Test

With proposed change the remote eval is detected:
Screenshot 2026-07-22 at 2 13 25 PM

Same remote eval running in 0.30.1 is not detected:
image

@stretpjc

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant