Repository navigation
fix(cursor): return valid responses from trace hooks - #161
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 744c80b75e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Andrew Kent (realark)
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Summary
Cursor's
beforeSubmitPrompthook expects a JSON response such as{"continue":true}. The tracing hook calledbt trace hookdirectly, so whenbtprinted CLI help or an error, Cursor treated that text as the hook response and blocked the prompt. Users saw “Hook blocked” followed by thebthelp output.How users hit it
It happens when Cursor runs the tracing hook and the CLI writes non-JSON output to stdout. Wrapping the command in a POSIX shell script fixes that case on Unix, but marketplace installs use the packaged
hooks.jsonverbatim on Windows, where the Windows hook runner cannot execute the.shlauncher.Fix
Keep the packaged hook commands as direct, cross-platform
bt trace hookinvocations. For Cursor events, the daemon now emits the expected protocol response after capture, including when capture fails:{"continue":true}forbeforeSubmitPromptand{}for other events. Each command passes its event explicitly sobtcan select the right response. This keeps CLI diagnostics from becoming Cursor policy output and works for direct marketplace installs on Windows as well as Unix.