Repository navigation
feat(tracing): separate plugin and bt span origin versions - #153
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c58cb82a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
c58cb82 to
d0dfbee
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0dfbee228
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
left a comment
Stephen Belanger (Qard)
left a comment
There was a problem hiding this comment.
Is it intentional that this only captures span_origin at session creation? That means we lose possibly useful information indicating if a coding agent has been upgraded mid-session.
This otherwise LGTM, but just want to be sure that loss of detail is intentional?
d0dfbee to
be1c5b3
Compare
be1c5b3 to
9dfa6d1
Compare
|
we should have made sure we merged in braintrustdata/braintrust-sdk-rust#109 and pointed to a commit on |
## Change Add `SpanLogBuilder::skip_span_origin()` to omit SDK-generated origin fields while retaining explicit and propagated context. The option persists through later handle logs and end; existing defaults are unchanged. Needed by braintrustdata/braintrust-coding-agent-plugins#153: legacy delivery ledgers have no origin snapshot, so late updates must preserve backend provenance rather than stamp SDK defaults or invent historical versions. ## Verification - Rust SDK suite: 215 passed, 5 ignored. - Clippy all targets with warnings denied: passed. - Daemon HTTP smoke: legacy merge delivered output/end timing without context/span_origin. - Daemon sink and provenance regression targets: 19 passed, including legacy ledgers across restarts and attached-parent context. --------- Co-authored-by: Stephen Belanger <stephen.belanger@braintrustdata.com> Co-authored-by: Stephen Belanger <admin@stephenbelanger.com>
4 participants
format: