Repository navigation
Fix Windows hook stalls caused by daemon handle inheritance - #152
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: beb87cbd8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
October 6, 2026 18:20
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix SDK-495. On Windows, a hook's detached
btdaemon inherited the write ends of the hook's stdout and stderr pipes. Codex waited for EOF after the hook process exited and remained stuck until the daemon was killed.Launch the Windows daemon with
CreateProcessWand an explicit inherited handle list containing only itsNULstdin and log stdout/stderr handles. Keep the existing Unix launch behavior. Add a Windows regression test that requires hook pipe EOF while the daemon remains alive.Validation
cargo test --locked --features cli --lib daemon_does_not_hold_hook_output_pipes).btwith this patch and ran a real authenticated Codex 0.160.1 session with the installed Codex plugin.SessionStart,UserPromptSubmit, andStophooks all completed, Codex exited 0, and the daemon accepted all three events.cargo fmt --manifest-path bt-daemon/Cargo.toml --checkandgit diff --checkpassed.