Open
Conversation
…ss SSID and password are optionally configured via SSH ENV variables, provided that the user is properly auth'd via pubkeys.
852c6b5 to
2f68178
Compare
2f68178 to
6bd3beb
Compare
…the user should just have to see the generated WIFI PSK, IP and know whether the (UART) bridge has been established successfully. Everything else has been moved to debug log level
jubeormk1
reviewed
Mar 16, 2026
jubeormk1
reviewed
Mar 16, 2026
jubeormk1
reviewed
Mar 16, 2026
jubeormk1
reviewed
Mar 16, 2026
Autofix
reviewed
Mar 16, 2026
Autofix
reviewed
Mar 16, 2026
jubeormk1
reviewed
Mar 16, 2026
jubeormk1
reviewed
Mar 16, 2026
jubeormk1
requested changes
Mar 16, 2026
Collaborator
jubeormk1
left a comment
There was a problem hiding this comment.
Overall I like the way this is looking! But there are a couple of things:
- The board starts and the wifi is up but I cannot reach by ping or ssh ssh-stamp. We need to review what has changed.
- Opinion: I would apply the WiFi ENV_VAR at once given that there is no error parsing SSID or PSK once all the environment variables have been processed as I mentioned in an inline comment.
Owner
Author
jubeormk1
reviewed
Mar 16, 2026
| tcp_socket | ||
| } | ||
|
|
||
| pub async fn wifi_ssid(config: &'static SunsetMutex<SSHStampConfig>) -> String<63> { |
Collaborator
There was a problem hiding this comment.
While you have it fresh in your mind, could you add doc comments for what this function and wifi_up does? They retrieve the wifi_password and wifi_ssid from config.
Would it be reasonable defining these functions as part of config or you rather have them here because they are part of espressif configuration requirements?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes issue #63 and readies SSH Stamp for security audit in #7.
Implements WPA2-WPA3 security by default... there seems to be a problem (bug?) with WPA3-only mode on esp_hal I need to investigate further: NetworkManager mis-identifies the network as WEP and PMF is disabled (should be enabled/mandatory in WPA3).
TODO:
debug!()instead ofinfo!()so that the user sees the generated wifi password easily and can copy-paste it on their client easily.