Fast-Forward Merge with the upstream rust-bitcoin repository

.cargo/mutants.toml

@@ -0,0 +1,34 @@
+additional_cargo_args = ["--all-features"]
+examine_globs = ["units/src/**/*.rs", "primitives/src/**/*.rs"]
+exclude_globs = [
+    "units/src/amount/verification.rs" # kani tests
+]
+exclude_re = [
+    "impl Debug",
+    "impl Arbitrary",
+    "impl Display",
+    ".*Error",
+    "deserialize", # Skip serde mutation tests
+    "Iterator", # Mutating operations in an iterator can result in an infinite loop
+
+    # ----------------------------------Crate-specific exclusions----------------------------------
+    # Units
+    # src/amount/mod.rs
+    "parse_signed_to_satoshi", # Can't kill all mutants since there is no denomination smaller than Satoshi
+    "fmt_satoshi_in", # Related to formatting/display
+    "dec_width", # Replacing num /= 10 with num %=10 in a loop causes a timeout due to infinite loop
+    # src/locktime/relative.rs
+    "Time::to_consensus_u32", # Mutant from replacing | with ^, this returns the same value since the XOR is taken against the u16 with an all-zero bitmask
+    "FeeRate::fee_vb", # Deprecated
+    "FeeRate::fee_wu", # Deprecated
+
+    # primitives
+    "Sequence::from_512_second_intervals", # Mutant from replacing | with ^, this returns the same value since the XOR is taken against the u16 with an all-zero bitmask
+    "Opcode::classify", # Not possible to kill all mutants without individually checking every opcode classification
+    "Block<Checked>::cached_witness_root", # Skip getters
+    "Block<Checked>::transactions", # Skip getters
+    "Script::to_bytes", # Deprecated
+    "decode_cursor", # Mutating operations in decode_cursor can result in an infinite loop
+    "fmt_debug", # Mutants from formatting/display changes
+    "fmt_debug_pretty", # Mutants from formatting/display changes
+]

.github/workflows/README.md

@@ -22,11 +22,11 @@ Run from rust.yml unless stated otherwise. Unfortunately we are now exceeding th
 8.  `Docs`
 9.  `Docsrs`
 10. `Bench`
-11. `ASAN`
-12. `WASM`
-13. `Arch32bit`
-14. `Cross`
-15. `Embedded`
+11. `Arch32bit`
+12. `Cross`
+13. `Embedded`
+14. `ASAN`
+15. `WASM`
 16. `Kani`
 17. `Coveralls` - run by `coveralls.yml`
 18. `release` - run by `release.yml`

.github/workflows/cargo-semver-checks-version

@@ -1 +1 @@
-0.36.0
+0.40.0

.github/workflows/coveralls.yml

@@ -7,7 +7,7 @@ name: Code coverage with llvm-cov
 jobs:
   Coveralls:
     name: Code coverage - stable toolchain
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
     steps:

.github/workflows/cron-daily-fuzz.yml

@@ -11,7 +11,7 @@ on:
 jobs:
   fuzz:
     if: ${{ !github.event.act }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       matrix:
@@ -59,18 +59,18 @@ jobs:
           echo "Using RUSTFLAGS $RUSTFLAGS"
           cd fuzz && ./fuzz.sh "${{ matrix.fuzz_target }}"
       - run: echo "${{ matrix.fuzz_target }}" >executed_${{ matrix.fuzz_target }}
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: executed_${{ matrix.fuzz_target }}
           path: executed_${{ matrix.fuzz_target }}
 
   verify-execution:
     if: ${{ !github.event.act }}
     needs: fuzz
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
       - name: Display structure of downloaded files
         run: ls -R
       - run: find executed_* -type f -exec cat {} + | sort > executed

.github/workflows/cron-daily-kani.yml

@@ -5,7 +5,7 @@ on:
     - cron: '59 23 * * *'       # midnight every day.
 jobs:
   run-kani:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - name: 'Checkout your code.'
         uses: actions/checkout@v4

.github/workflows/cron-weekly-cargo-mutants.yml

@@ -0,0 +1,41 @@
+name: Weekly cargo-mutants
+on:
+  schedule:
+    - cron: "0 0 * * 0" # runs weekly on Sunday at 00:00
+  workflow_dispatch: # allows manual triggering
+jobs:
+  cargo-mutants:
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+      - uses: taiki-e/install-action@v2
+        with:
+          tool: cargo-mutants
+      - run: cargo mutants --in-place --no-shuffle
+      - uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: mutants.out
+          path: mutants.out
+      - name: Check for new mutants
+        if: always()
+        run: |
+          if [ -s mutants.out/missed.txt ]; then
+            echo "New missed mutants found"
+            gh issue create \
+            --title "New Mutants Found" \
+            --body "$(cat <<EOF
+          Displaying up to the first 10 mutants:
+
+          $(head -n 10 mutants.out/missed.txt)
+
+          For the complete list, please check the [mutants.out artifact](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}).
+          EOF
+          )"
+            echo "create_issue=true" >> $GITHUB_ENV
+          else
+            echo "No new mutants found"
+            echo "create_issue=false" >> $GITHUB_ENV
+          fi
+    env:
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/cron-weekly-rustfmt.yml

@@ -6,7 +6,7 @@ on:
 jobs:
   format:
     name: Nightly rustfmt
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@nightly

.github/workflows/cron-weekly-update-cargo-semver-checks.yml

@@ -6,7 +6,7 @@ on:
 jobs:
   format:
     name: Update cargo-semver-checks
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
       - name: Update semver-checks to use latest crates.io published version

.github/workflows/cron-semi-weekly-update-nightly.yml → .github/workflows/cron-weekly-update-nightly.yml

@@ -1,12 +1,12 @@
 name: Update Nightly rustc
 on:
   schedule:
-    - cron: "5 0 * * 1,4" # runs every Monday and Thursday at 00:05
+    - cron: "5 0 * * 6" # Saturday at 00:05
   workflow_dispatch: # allows manual triggering
 jobs:
   format:
     name: Update nightly rustc
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@nightly

.github/workflows/cron-weekly-update-stable.yml

@@ -6,7 +6,7 @@ on:
 jobs:
   format:
     name: Update stable rustc
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable

.github/workflows/gh-release.yml

@@ -7,7 +7,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
     - uses: actions/checkout@v4
     - uses: ncipollo/release-action@v1

.github/workflows/manage-pr.yml

@@ -7,7 +7,7 @@ jobs:
     permissions:
       contents: read
       pull-requests: write
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout master
         uses: actions/checkout@v4

.github/workflows/miri.yml

@@ -11,7 +11,7 @@ name: Miri
 jobs:
   Miri:
     name: Miri
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
     steps:

.github/workflows/release.yml

@@ -12,7 +12,7 @@ name: Release
 jobs:
   release:
     name: Release - dry-run
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v4