fix: address P1 and P2 issues from code review#215
Merged
Conversation
Branded error page with header, footer, and link back to tutorial home. Includes noindex meta tag and dark mode support. Closes #212 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set:htmlXSS risk in Footer — use plain text interpolation (Fix set:html XSS risk in Footer component #208)import.meta.env.SITE+BASE_URL(Fix hardcoded JSON-LD URLs (braboj.github.io vs braboj.me) #209)--color-linkfrom#4dd0e1(6.1:1) to#00bcd4(7.3:1) for WCAG AAA (Fix dark mode link contrast for WCAG AAA compliance #210).search-boxCSS (Remove unused search box CSS (~60 dead lines) #211)Closes #208, closes #209, closes #210, closes #211
Test plan
braboj.menotbraboj.github.io