Conversation
|
I'm with you on this - coding style is essential in librarys, but probably this won't get merged :-( BTW: #defines are precompiler-commands and are no longer good practice. 10 years ago yes, but now it's better to use "static const _type =(##);" instead. Result is nearly the same, but you get much more helpful errors and warnings. |
|
This is a great addition thanks. can't believe nobody mentioned that before! I hesitate to reply to your comment orgua, as it reads (to me anyway) more like a venting of frustration over pull request 26 than a comment on this request. But... I can see how it would be frustrating from your side, and probably owe some sort of explanation. Why did PR #27 and #24 get merged, and why have I dragged my feet on #26 (yours)? 2 reasons: one legitimate, and one stupid. Legitimate: before release, I spent literally months perfecting and refining the working code of the library. This thing for example. I feel that if I'm going to change anything about the internals of the library, I need to make sure I do justice to that effort, and strictly vet any changes. It's hard to make time for that at this point in my life (THIS thing.) #27 #24 were high-value / peripheral changes that I completely understood. Your changes will require some education on my part to get comfortable with them. Stupid: I'm proud of my work, and I want to be able to say that I'm solely responsible for this library. This is clearly bullshit, and something that I need to let go of. ESPECIALLY since I can't invest the time anymore to do everything myself. So here's the deal. I'm going to go over to #26 in a couple of hours and ask you some questions to try to become satisfied with the changes you've suggested. It's quite likely that I'll get what I need, at which point I'll merge your request. |
|
Thank you for your work @br3ttb :) |
Hi,
I made some edits of the examples, to make them easier to reuse for newcomers.
Thanks!