update Compute() so it computes on the first call#109
Open
tlatorre-uchicago wants to merge 1 commit intobr3ttb:masterfrom
Open
update Compute() so it computes on the first call#109tlatorre-uchicago wants to merge 1 commit intobr3ttb:masterfrom
tlatorre-uchicago wants to merge 1 commit intobr3ttb:masterfrom
Conversation
|
Thought provoking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change to update Comput() so that it produces a non-zero output on the first call. The issue I noticed was that the PID output after the first call was always zero. I guess for most setups this wouldn't be a big issue. The reason it is for me is that I'm using the PID output to set the duty cycle for a relay controlling a fridge, and the time window is 15 minutes. Therefore, every time I restarted the Arduino it would turn off the fridge for 15 minutes. I thought this might be useful to other people so I'm submitting this pull request.