feat(content-preview): forward monitoring dimensions#4542
Conversation
Accept accessPattern, previewMode, sharedLinkAuth as props on ContentPreview and pass them through to the underlying Preview library so emitted metric/error events are tagged for the monitoring dashboard. PREVIEW-225 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughContentPreview Props gain three optional monitoring fields ( ChangesPreview Monitoring Dimensions
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Accepts two new optional props on ContentPreview — prefetchStatus and preloadStatus — and threads them into previewOptions so box-content-preview can tag emitted load/error/outcome events. PREVIEW-225 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
box-content-preview now derives both signals internally. The wrapper no longer accepts these props. PREVIEW-225 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Wrapper accepts preloadStatus prop and threads it into previewOptions so box-content-preview can tag emitted load/error/outcome events. PREVIEW-225 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
| previewLibraryVersion: string, | ||
| requestInterceptor?: Function, | ||
| responseInterceptor?: Function, | ||
| accessPattern?: 'file_list' | 'direct_link' | 'shared_link', |
There was a problem hiding this comment.
can we sort these new props, looks like current ones are sorted
Addresses PR comment: merge the 4 new monitoring-dimension props into alphabetical order with the existing Props type members. PREVIEW-225 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Accepts four new optional props on `` and threads them into `previewOptions` so the underlying Preview library can tag emitted `preview_metric` / `preview_error` events for a performance monitoring dashboard:
All four props are optional; when omitted the underlying library defaults behavior is preserved.
Test plan
Summary by CodeRabbit
Release Notes