Skip to content

fix: Allow xml-model processing instruction in Psr1PhpTagsRule #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Nov 13, 2026
Merged

fix: Allow xml-model processing instruction in Psr1PhpTagsRule #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Util/InlineHtmlOpeningTagMatcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

final class InlineHtmlOpeningTagMatcher
{
private const ALLOWED_TAGS = 'php|xml|xml\-stylesheet';
private const ALLOWED_TAGS = 'php|xml|xml-stylesheet|xml-model';

public static function invalidInlineHtmlTagOffset(string $text, int $offset = 0): ?int
{
Expand Down
2 changes: 2 additions & 0 deletions tests/Analyser/FileAnalysisProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,8 @@ public static function lightweightAnalysisProvider(): iterable
yield 'echo tag' => ['<?= "echo";', false, true, null];
yield 'XML declaration' => ['<?xml version="1.0"?>', false, true, null];
yield 'XML stylesheet' => ['<?xml-stylesheet href="style.xsl"?>', false, true, null];
yield 'XML model' => ['<?xml-model href="schema.rng"?>', false, true, null];
yield 'XML model lookalike' => ['<?xml-models href="schema.rng"?>', false, true, 1];
yield 'arbitrary XML processing instruction' => ['<?xml-custom value="x"?>', false, true, 1];
yield 'plain text' => ['plain text', false, true, null];
}
Expand Down
Loading