Skip to content

Reuse the endpoint of the checkpointed container when restore#7

Open
huikang wants to merge 29 commits intoboucher:cr-combinedfrom
huikang:cr-combined-ep-fix
Open

Reuse the endpoint of the checkpointed container when restore#7
huikang wants to merge 29 commits intoboucher:cr-combinedfrom
huikang:cr-combined-ep-fix

Conversation

@huikang
Copy link

@huikang huikang commented Jun 19, 2015

Docker-DCO-1.1-Signed-off-by: Hui Kang hkang.sunysb@gmail.com

Saied Kazemi and others added 9 commits June 16, 2015 14:54
@boucher
Checkpoint/Restore Support: add exec driver methods
08507cf 
Methods for checkpointing and restoring containers were added to the
native driver.  The LXC driver returns an error message that these
methods are not implemented yet.

Signed-off-by: Saied Kazemi <saied@google.com>

Conflicts:
	daemon/execdriver/native/create.go
	daemon/execdriver/native/driver.go
	daemon/execdriver/native/init.go
@boucher
Update checkpoint/restore support to match docker/master
5d19d1a 
Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@boucher
Checkpoint/Restore Support: add functionality to daemon
de50b10 
Support was added to the daemon to use the Checkpoint and Restore methods
of the native exec driver for checkpointing and restoring containers.

Signed-off-by: Saied Kazemi <saied@google.com>

Conflicts:
	api/server/server.go
	daemon/container.go
	daemon/daemon.go
	daemon/networkdriver/bridge/driver.go
	daemon/state.go
	vendor/src/github.com/docker/libnetwork/ipallocator/allocator.go
@huikang @boucher
Release the network resource during checkpoint
55fcafa 
Restore failed if network resource not released during checkpoint,
e.g., a container with port open with -p

Signed-off-by: Hui Kang <hkang.sunysb@gmail.com>

Conflicts:
	daemon/container.go
@boucher
Update daemon and cli support for checkpoint and restore.
7c45210 
Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@boucher
Add compilation steps for Criu to the Dockerfile
5638d05 
Add a basic test for checkpoint/restore to the integration tests

Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@boucher
Add optional dependency info to the PACKAGERS file.
931ab3c 
Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@boucher
Don't destroy/delete the container if it has been checkpointed.
25627f6 
Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@huikang
Reuse the endpoint of the checkpointed container when restore
637d7ac 
Docker-DCO-1.1-Signed-off-by: Hui Kang <hkang.sunysb@gmail.com>
@huikang
Copy link
Author

huikang commented Jun 19, 2015

@boucher This PR fixes the network endpoint problem when restoring a container. The endpoint should be reused by a checkpointed container so that the network resources (e.g., iptable rule) will not be changed after restoring. Please review if it fits into your branch. Thanks.

@boucher
Copy link
Owner

boucher commented Jun 19, 2015

If I run this code, and then checkpoint and restore a container, it still can't access the network. I believe this is related to the issue I filed here: moby#14027

(To test, I just exec'd into the restored container and tried ping'ing google.com) Are you actually able to use the network after a restore?

Saied Kazemi and others added 4 commits June 23, 2015 10:43
@boucher
Checkpoint/Restore Support: add exec driver methods
56cd5a1 
Methods for checkpointing and restoring containers were added to the
native driver.  The LXC driver returns an error message that these
methods are not implemented yet.

Signed-off-by: Saied Kazemi <saied@google.com>

Conflicts:
	daemon/execdriver/native/create.go
	daemon/execdriver/native/driver.go
	daemon/execdriver/native/init.go
@boucher
Update checkpoint/restore support to match docker/master
456ecbf 
Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@boucher
Checkpoint/Restore Support: add functionality to daemon
34bd07f 
Support was added to the daemon to use the Checkpoint and Restore methods
of the native exec driver for checkpointing and restoring containers.

Signed-off-by: Saied Kazemi <saied@google.com>

Conflicts:
	api/server/server.go
	daemon/container.go
	daemon/daemon.go
	daemon/networkdriver/bridge/driver.go
	daemon/state.go
	vendor/src/github.com/docker/libnetwork/ipallocator/allocator.go
@huikang @boucher
Release the network resource during checkpoint
ca085a8 
Restore failed if network resource not released during checkpoint,
e.g., a container with port open with -p

Signed-off-by: Hui Kang <hkang.sunysb@gmail.com>

Conflicts:
	daemon/container.go
@boucher boucher force-pushed the cr-combined branch 3 times, most recently from 7bc31ef to af5a67b Compare June 23, 2015 20:32
boucher added 4 commits June 23, 2015 13:44
@boucher
Update daemon and cli support for checkpoint and restore.
d06dedf 
Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@boucher
Add compilation steps for Criu to the Dockerfile
87179b4 
Add a basic test for checkpoint/restore to the integration tests

Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@boucher
Add optional dependency info to the PACKAGERS file.
b8cebfc 
Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@boucher
Don't destroy/delete the container if it has been checkpointed.
c1a59ac 
Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@huikang
Reuse endpoint for 1.8.0-dev
297994e 
Docker-DCO-1.1-Signed-off-by: Hui Kang <hkang.sunysb@gmail.com>

Merge branch 'cr-combined' into cr-combined-ep-fix

Conflicts:
	daemon/container.go
	daemon/container_linux.go
@huikang
Copy link
Author

huikang commented Jun 29, 2015

@boucher Update the patch for 1.8.0-dev, but the problem you described still exists. I will look into this issue these days.

Saied Kazemi and others added 4 commits July 9, 2015 09:20
@boucher
Checkpoint/Restore Support: add exec driver methods
b654a74 
Methods for checkpointing and restoring containers were added to the
native driver.  The LXC driver returns an error message that these
methods are not implemented yet.

Signed-off-by: Saied Kazemi <saied@google.com>

Conflicts:
	daemon/execdriver/native/create.go
	daemon/execdriver/native/driver.go
	daemon/execdriver/native/init.go
@boucher
Update checkpoint/restore support to match docker/master
90f5917 
Docker-DCO-1.1-Signed-off-by: Ross Boucher <rboucher@gmail.com> (github: boucher)
@boucher
Checkpoint/Restore Support: add functionality to daemon
a3b970f 
Support was added to the daemon to use the Checkpoint and Restore methods
of the native exec driver for checkpointing and restoring containers.

Signed-off-by: Saied Kazemi <saied@google.com>

Conflicts:
	api/server/server.go
	daemon/container.go
	daemon/daemon.go
	daemon/networkdriver/bridge/driver.go
	daemon/state.go
	vendor/src/github.com/docker/libnetwork/ipallocator/allocator.go
@huikang @boucher
Release the network resource during checkpoint
b3c2a8e 
Restore failed if network resource not released during checkpoint,
e.g., a container with port open with -p

Signed-off-by: Hui Kang <hkang.sunysb@gmail.com>

Conflicts:
	daemon/container.go
@boucher boucher force-pushed the cr-combined branch 4 times, most recently from 8f69143 to 59c375a Compare August 11, 2015 23:39
@boucher boucher force-pushed the cr-combined branch 5 times, most recently from 5dda3d1 to 183488f Compare October 6, 2015 18:13
@boucher boucher force-pushed the cr-combined branch 4 times, most recently from e91c518 to 988a915 Compare November 3, 2015 17:17
@boucher boucher force-pushed the cr-combined branch 2 times, most recently from b584b5a to a6a4511 Compare November 12, 2015 17:00
@boucher boucher force-pushed the cr-combined branch 4 times, most recently from 7c96921 to 7fda470 Compare December 5, 2015 01:35
@boucher boucher force-pushed the cr-combined branch 8 times, most recently from d80f2fb to 9272300 Compare December 17, 2015 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huikang @boucher