Skip to content

feat(docs): add adk and desk section on main docs#27

Open
janelletam wants to merge 4 commits into
janelle/docs-v2/visual-differencesfrom
janelle/docs-v2/adk-desk-migration
Open

feat(docs): add adk and desk section on main docs#27
janelletam wants to merge 4 commits into
janelle/docs-v2/visual-differencesfrom
janelle/docs-v2/adk-desk-migration

Conversation

@janelletam
Copy link
Copy Markdown
Contributor

@janelletam janelletam commented May 29, 2026

Summary

  • Add initial ADK and Desk sections to docs-v2 underneath the "Docs" tab
  • Register both sections in bach.config.ts for navbar and routes
  • Include light/dark image assets for the ADK quickstart

Test plan

  • Verify ADK quickstart page renders with correct images in light/dark mode
  • Verify Desk introduction page renders without errors
  • Confirm both sections appear in the sidebar navigation

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 29, 2026

Greptile Summary

This PR adds ADK and Desk sections to the main docs sidebar, introduces two new documentation stub pages (adk/quickstart.mdx and desk/introduction.mdx), fixes a runtime-breaking typo in the chevron icon constant names in code-copy.ts, and swaps the link icon in Step.astro from the project's Icon.astro wrapper to a direct lucide-react import.

  • Sidebar config (bach.config.ts): Two new sidebar groups (ADK, Desk) pointing to the new pages — straightforward addition.
  • Bug fix (code-copy.ts): Corrects CHEVRON_DOWN_ICON_ICON / CHEVRON_UP_ICON_ICON to CHEVRON_DOWN_ICON / CHEVRON_UP_ICON, which didn't match the actual exports and left the expand/collapse labels broken at runtime.
  • Step icon (Step.astro): Switches from Icon.astro to a raw lucide-react component; functionally equivalent, but slightly inconsistent with the rest of the codebase's icon conventions.

Confidence Score: 5/5

Safe to merge — the changes are additive documentation stubs with a targeted bug fix; no existing functionality is broken.

The only substantive code change is fixing the typo in chevron icon import names, which was clearly broken before. The new docs pages are stubs that don't touch any shared logic. The Step.astro icon swap works correctly at runtime.

No files require special attention, though it's worth confirming whether the unused images in src/content/docs/adk/assets/ are intentionally deferred or accidentally omitted from the MDX page.

Important Files Changed

Filename Overview
src/components/Step.astro Replaces custom Icon.astro with a direct lucide-react Link component; className is correct for React in Astro, and size-3 now applies without conflicting with Icon.astro's forced size-4.
src/scripts/code-copy.ts Fixes typo in imported constant names (CHEVRON_DOWN_ICON_ICON → CHEVRON_DOWN_ICON, CHEVRON_UP_ICON_ICON → CHEVRON_UP_ICON) to match actual exports; the old names were undefined at runtime, breaking expand/collapse.
src/content/docs/adk/quickstart.mdx New ADK quickstart stub with a Card linking to /adk; two image assets were added to the same directory but are not referenced in this file.
src/content/docs/desk/introduction.mdx New Desk introduction page with feature list and contact CTA card; content and Badge usage look correct.
bach.config.ts Adds ADK and Desk sidebar groups pointing to the two new documentation pages; straightforward config addition.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Main Docs Sidebar] --> B[Cloud]
    A --> C[ADK NEW]
    A --> D[Desk NEW]
    A --> E[Tutorial]
    C --> C1[adk/quickstart - Get started]
    C1 --> C2[Card: /adk Full ADK docs]
    D --> D1[desk/introduction - Introduction]
    D1 --> D2[Card: botpress.com/contact-us Sales CTA]
Loading

Reviews (2): Last reviewed commit: "fix(docs): fix incorrect import" | Re-trigger Greptile

Comment thread pnpm-workspace.yaml Outdated
Comment thread src/components/mobile-sidebar.tsx Outdated
Comment thread .claude/commands/docs-migrator.md
@janelletam janelletam force-pushed the janelle/docs-v2/adk-desk-migration branch 3 times, most recently from b31c3b2 to 09453f6 Compare May 29, 2026 16:03
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@janelletam janelletam force-pushed the janelle/docs-v2/visual-differences branch from 0865088 to 68902b5 Compare May 29, 2026 18:37
@janelletam janelletam force-pushed the janelle/docs-v2/adk-desk-migration branch from 09453f6 to 1264743 Compare May 29, 2026 18:37
@janelletam janelletam changed the title feat(docs): add adk & desk section on main docs feat(docs): add adk and desk section on main docs May 29, 2026
@janelletam
Copy link
Copy Markdown
Contributor Author

@greptileai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant