perf(scaffold): strip template docs from products + cache API eslint#304
Merged
Conversation
…loss) The UI already caches ESLint; the API did not, so every gate cycle paid ~23s per lint AND another ~23s when lint ran again in the check. Content-based cache invalidation, no rules changed. .eslintcache + *.tsbuildinfo gitignored.
…hecks template-only apps/docs is boringstack's OWN docs site — a scaffolded product must not carry or gate against it. Manifest declares strip:[apps/docs] for the full-stack archetype (tsforge deletes it post-clone). stack-check.sh now skips the docs checks (data + build:ci/og-image) when apps/docs is absent, so a product passes cleanly while the template itself (which keeps apps/docs) still checks it fully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes that make tsforge-driven builds against a scaffolded product faster and correct:
1. Strip
apps/docsfrom scaffolded productsapps/docsis boringstack's OWN documentation site. A product scaffolded from the template was carrying it AND gating against it — itsdocs build:ci/generate:og-imagefails in a headless build env, blocking the gate on something the product's author can't fix..tsforge/scaffold-manifest.json: theboringstack(full-stack) archetype declaresstrip: ["apps/docs"]; tsforge deletes it post-clone. Archetype-scoped — theastroarchetype (whose product IS apps/docs) strips nothing.scripts/stack-check.sh: docs checks (docs data,docs build:ci) are now guarded onapps/docsexisting. The template repo keeps apps/docs and still checks it fully; a stripped product skips them cleanly.2.
eslint --cacheon the APIThe UI already caches ESLint; the API didn't, so every gate cycle paid ~23s per lint (twice — once as
lint:fix, once as thechecklint). Content-based cache invalidation, zero rule changes. Warm lint ~23s → ~2s..eslintcache+*.tsbuildinfogitignored.Config-only; no rules relaxed.