properly handle invalid and dev versions in version parser, fixes #9014#9608
Open
ThomasWaldmann wants to merge 1 commit into
Open
properly handle invalid and dev versions in version parser, fixes #9014#9608ThomasWaldmann wants to merge 1 commit into
ThomasWaldmann wants to merge 1 commit into
Conversation
…borgbackup#9014 - `src/borg/__init__.py`: The `setuptools_scm` fallback version `0.1.dev1` was incorrectly bypassing the assertion check (as `0` and `1` are valid integers), which hid the intended helpful error message when building from source without tags. Added an explicit check for the `0.1.dev` prefix. - `src/borg/version.py`: `parse_version` and `format_version` have been updated to correctly understand `setuptools_scm`'s `.dev` or `dev` prefixes. These dev releases are now properly encoded in the version tuple as `-9` (which logically makes them older than alphas `-4`, betas `-3`, rcs `-2`, and final `-1`), and correctly reformatted to `.dev` strings.
ThomasWaldmann
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #9608 +/- ##
=============================================
+ Coverage 81.93% 82.00% +0.07%
=============================================
Files 38 38
Lines 11327 11327
Branches 1787 1787
=============================================
+ Hits 9281 9289 +8
+ Misses 1461 1453 -8
Partials 585 585 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/borg/__init__.py: Thesetuptools_scmfallback version0.1.dev1was incorrectly bypassing the assertion check (as0and1are valid integers), which hid the intended helpful error message when building from source without tags. Added an explicit check for the0.1.devprefix.src/borg/version.py:parse_versionandformat_versionhave been updated to correctly understandsetuptools_scm's.devordevprefixes. These dev releases are now properly encoded in the version tuple as-9(which logically makes them older than alphas-4, betas-3, rcs-2, and final-1), and correctly reformatted to.devstrings.