tmpfiles: Tolerate EACCES when resolving declared paths - #2382
Open
gursewak1997 wants to merge 1 commit into
Open
tmpfiles: Tolerate EACCES when resolving declared paths#2382gursewak1997 wants to merge 1 commit into
gursewak1997 wants to merge 1 commit into
Conversation
gursewak1997
force-pushed
the
bootc2379
branch
from
August 14, 2026 19:19
6c4d0df to
fc71c5f
Compare
cgwalters
requested changes
Aug 17, 2026
Comment on lines
+116
to
+117
| // Tolerate inaccessible paths (EACCES in rootless containers, | ||
| // ENOSYS under QEMU emulation). |
Collaborator
There was a problem hiding this comment.
ENOSYS is a totally different thing, I don't think we should conflate with EPERM.
In the qemu/ENOSYS case the functionality won't work at all for any file. I think it'd be cleaner for that case to do a "does it work" probe and have a clear warning if it doesn't.
It's just a different bug.
The path canonicalization added in cfec5cc opens the parent directory of every declared tmpfiles.d path to get its (dev, ino) identity. Entries like selinux-policy's `w /sys/fs/selinux/checkreqprot` point at virtual filesystem paths that return EACCES in rootless containers. Treat these the same as a missing parent — return None — since the /var walker cannot encounter inaccessible paths either. Fixes: bootc-dev#2379 Assisted-by: AI Signed-off-by: gursewak1997 <gursmangat@gmail.com>
gursewak1997
force-pushed
the
bootc2379
branch
from
August 17, 2026 18:46
fc71c5f to
d4ce837
Compare
gursewak1997
changed the title
cgwalters
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The path canonicalization added in cfec5cc opens the parent directory of every declared tmpfiles.d path to get its
(dev, ino)identity. Entries like selinux-policy'sw /sys/fs/selinux/checkreqprotpoint at virtual filesystem paths that return EACCES in rootless containers. Treat these the same as a missing parent — returnNone— since the/varwalker cannot encounter inaccessible paths either.Fixes: #2379
Test plan
test_resolve_parent_identity_permission_deniedcreates a mode-0o000 directory and verifies EACCES returnsOk(None)instead of a fatal errorbootc container lintin a rootlessquay.io/centos-bootc/centos-bootc:c10scontainer (which ships the triggeringselinux-policy.confentry)Assisted-by: AI