deploy: Pull bound images before staging via composefs mount - #2290
Open
cgwalters wants to merge 2 commits into
Open
deploy: Pull bound images before staging via composefs mount#2290cgwalters wants to merge 2 commits into
cgwalters wants to merge 2 commits into
Conversation
Contributor
|
Needs |
cgwalters
force-pushed
the
lbi-pull-reliability
branch
from
July 8, 2026 11:51
d754a3e to
198b725
Compare
gursewak1997
previously approved these changes
Jul 8, 2026
cgwalters
force-pushed
the
lbi-pull-reliability
branch
from
July 8, 2026 20:38
198b725 to
599b688
Compare
cgwalters
enabled auto-merge
July 8, 2026 20:58
cgwalters
force-pushed
the
lbi-pull-reliability
branch
from
July 9, 2026 15:20
599b688 to
330bcb9
Compare
cgwalters
added this pull request to the merge queue
Jul 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 10, 2026
Collaborator
Author
Looks legit |
cgwalters
force-pushed
the
lbi-pull-reliability
branch
2 times, most recently
from
July 28, 2026 19:33
40b03f3 to
74f6c22
Compare
cgwalters
enabled auto-merge
July 28, 2026 19:59
Collaborator
Author
|
OK, this one should be good to go now |
jmarrero
previously approved these changes
Jul 29, 2026
cgwalters
added this pull request to the merge queue
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
Collaborator
Author
|
Hmm, hitting #2340 on this on centos-9. |
cgwalters
force-pushed
the
lbi-pull-reliability
branch
from
July 29, 2026 20:43
8207128 to
74c96e9
Compare
Collaborator
Author
|
OK this rolls in the fix for that |
cgwalters
added
ci/merge
1 task
…ck fallback
CentOS Stream 9 ships kernel 5.14, which cannot mount an erofs image
directly from a file descriptor. composefs-rs provides a `rhel9` feature
in composefs-ctl (and forwarded through bootc-initramfs-setup) that works
around this by loopifying the image file into a /dev/loopN block device
before mounting it.
Without this feature enabled at build time, bootc install on centos-9 with
the composefs backend fails with ENOTBLK ('Block device required', errno 15)
when the initramfs setup code tries to mount the composefs/erofs image.
Wire up the feature in two places:
- Makefile: extend CARGO_FEATURES_DEFAULT to also emit `rhel9` when
building on a RHEL-like OS with VERSION_ID=9.
- bootc.spec: add a `rhel9` bcond gated on `%{?rhel} == 9` and pass
it to all three cargo build invocations and to %make_install.
With the build fix in place, remove the ci.yml exclude that was
suppressing centos-9 + composefs testing in test-integration.
Closes: bootc-dev#1812
Assisted-by: AI
Signed-off-by: Colin Walters <walters@verbum.org>
We were still staging a new bootloader entry even when we failed to pull a LBI. Switch to only doing an image pull and not a deployment, then pulling referenced LBIs from that. The "bound_images" progress subtask moves earlier in the sequence accordingly, ahead of "deploying" instead of after it, since the pull now happens before deploy() is called. Closes: bootc-dev#2013 Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
lbi-pull-reliability
branch
from
July 31, 2026 13:32
74c96e9 to
1dcfd17
Compare
Collaborator
Author
|
Looks like there are some potential latent issues with general tests on c9s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were still staging a new bootloader entry even when we failed to pull a LBI. Switch to only doing an image pull and not a deployment, then pulling referenced LBIs from that.
Closes: #2013