composefs: add a systemd.mount-extra kernel argument to the BLS boot entry#2121
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Apr 3, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that the /boot partition is correctly mounted after reboot in the composefs path by writing the appropriate entry to /etc/fstab in the deployment's state directory. To support this, the boot field in RootSetup was made crate-visible. Feedback suggests using the existing directory handle for relative path operations instead of absolute paths and utilizing labeled atomic writes to ensure correct SELinux context for the new fstab file.
Collaborator
|
What's the OS version? I really want to get away from the For |
The composefs install path was not ensuring /boot gets mounted after reboot on systems with a separate /boot partition (e.g. to-existing-root installs). This broke `bootc status` and `bootc upgrade`. Instead of writing to /etc/fstab (which conflicts with transient etc per bootc-dev#1388), add a systemd.mount-extra kernel argument to the BLS boot entry. This tells systemd to mount the boot partition without requiring any /etc state. Closes: bootc-dev#2120 Assisted-by: Claude Code (Opus 4.6) Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
henrywang
force-pushed
the
fix-composefs-boot-fstab
branch
from
37e4c0d to
8e579ad
Compare
henrywang
changed the title
cgwalters
approved these changes
Apr 3, 2026
Collaborator
Author
It's Fedora 43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composefs install path was not ensuring /boot gets mounted after reboot on systems with a separate /boot partition (e.g. to-existing-root installs). This broke
bootc statusandbootc upgrade.Instead of writing to /etc/fstab (which conflicts with transient etc per #1388), add a systemd.mount-extra kernel argument to the BLS boot entry. This tells systemd to mount the boot partition without requiring any /etc state.
Closes: #2120
Assisted-by: Claude Code (Opus 4.6)