Skip to content

Conversation

@henrywang
Copy link
Collaborator

Fix bib test failure with error: cannot build manifest: no default fs set: mount "/boot" requires a filesystem but none set.
Add bib test required package qemu-img into packages.txt.

error: cannot build manifest: no default fs set: mount "/boot"
requires a filesystem but none set

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
@bootc-bot bootc-bot bot requested a review from jeckersb January 23, 2026 02:59
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a test failure in the bib-build test. The changes are twofold: first, it adds the qemu-img package to hack/packages.txt, which is a necessary dependency for the test. Second, it modifies the podman run command in tmt/tests/booted/test-bib-build.nu to include the --rootfs xfs argument, which explicitly sets the root filesystem type and resolves the error cannot build manifest: no default fs set. Both changes are correct and directly address the issues described. The PR is well-focused and looks good to merge.

@Johan-Liebert1 Johan-Liebert1 mentioned this pull request Jan 23, 2026
Copy link
Collaborator

@Johan-Liebert1 Johan-Liebert1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters cgwalters merged commit fece2e0 into bootc-dev:main Jan 23, 2026
49 of 52 checks passed
@henrywang henrywang deleted the fix-bib-failure branch January 23, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants