install: support configuring sysroot.bls-append-except-default #1909
+141
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for configuring sysroot.bls-append-except-default for ostree during installation. The changes are well-structured, introducing the necessary configuration options and the logic to apply them. The new functionality is also covered by a test case. I've provided a couple of suggestions to improve code readability and remove duplication.
jbtrystram
suggested changes
Jan 20, 2026
joelcapitao
force-pushed
the
feat-grubusers
branch
3 times, most recently
from
c13cf9e to
b806975
Compare
jbtrystram
reviewed
Jan 21, 2026
joelcapitao
force-pushed
the
feat-grubusers
branch
from
b806975 to
acec07a
Compare
Contributor
Author
|
It looks like the packit failures are not related to this patch |
cgwalters
requested changes
Jan 21, 2026
Collaborator
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Please update the install config docs for this.
We could probably also add this option to one of our existing install tests too (we have a bunch).
Otherwise I just have nits.
cgwalters
force-pushed
the
feat-grubusers
branch
from
acec07a to
41ba1ac
Compare
Collaborator
|
I rebased 🏄 this btw alongside other outstanding PRs |
joelcapitao
force-pushed
the
feat-grubusers
branch
from
41ba1ac to
44f974a
Compare
github-actions
bot
added
area/ostree
joelcapitao
force-pushed
the
feat-grubusers
branch
2 times, most recently
from
9de6c8f to
ed03854
Compare
Add a new [install.ostree] configuration section to allow setting the ostree sysroot.bls-append-except-default option during installation. Closes: bootc-dev#1710 Signed-off-by: Joel Capitao <jcapitao@redhat.com> Co-authored-by: Jean-Baptiste Trystram <jbtrystram@redhat.com> Assisted-by: Claude (Sonnet 4)
joelcapitao
force-pushed
the
feat-grubusers
branch
from
ed03854 to
f71a343
Compare
joelcapitao
added a commit
to joelcapitao/osbuild
that referenced
this pull request
Jan 22, 2026
Add support for the new [install.ostree] configuration section with the bls-append-except-default option, which was introduced in bootc PR osbuild#1909 [1] This option allows setting the ostree sysroot.bls-append-except-default config key during installation, which appends kernel arguments to Boot Loader Spec entries except for the default entry. A common use case is setting grub_users="" to bypass GRUB password prompts for non-default deployments. Example usage in manifest: { "type": "org.osbuild.bootc.install.config", "options": { "filename": "10-custom.toml", "config": { "install": { "ostree": { "bls-append-except-default": "grub_users=\"\"" } } } } } [1] bootc-dev/bootc#1909 Signed-off-by: Joel Capitao <jcapitao@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new [install.ostree] configuration section to allow setting the ostree sysroot.bls-append-except-default option during installation.
Closes: #1710
Signed-off-by: Joel Capitao jcapitao@redhat.com
Co-authored-by: Jean-Baptiste Trystram jbtrystram@redhat.com
Assisted-by: Claude (Sonnet 4)