Repository navigation
fix: degrade condition overwritten by the next reconcile (backport #220) - #230
Merged
Merged
Conversation
Replace the blanket Degraded=False reset at the top of each reconcile with per-reason clearing. Each check clears its own degraded reason on success via clearPoolDegradedReason, and rollout-path reasons are cleared before syncMembership/driveRollout re-evaluate them. This avoids the False->True->False ping-pong on LastTransitionTime that caused a spurious status write every reconcile when tag resolution was deferred. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com> (cherry picked from commit 1c1997c)
alicefr
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tag resolution fails for a BootcNodePool, the Degraded condition is correctly set but lost on the next reconcile: the blanket healthy-reset clears it and the deferred resolution path returns early without re-applying it.
Re-set the TagResolutionError condition when resolution is not yet due and TargetDigest is still empty, meaning no prior resolution has succeeded.
Fixes: #217
This is an automatic backport of pull request #220 done by Mergify.