Repository navigation
Conversation
Parallel E2E tests create daemon pods on other managed nodes. Restrict the membership lookup to its own node so unrelated pods do not cause the exactly-one assertion to time out. Refs: bootc-dev#226 Refs: bootc-dev#203 Assisted-by: AI Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
HarshwardhanPatil07
force-pushed
the
fix-controller-membership-node-filter
branch
from
October 12, 2026 08:34
a18fd2b to
2a44785
Compare
The rollout permits one reboot at a time. Waiting in node creation order can spend the queued node’s completion budget on the first node finishing two image transitions. Wait for the already-rebooting node first so the queued node receives its own bounded completion window. Keep the eight-minute per-node timeout, final-image checks, and exactly-one-reboot assertion unchanged. CI must confirm recovery; transient networking errors alone do not establish a permanent failure. Refs: bootc-dev#229 Assisted-by: AI Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
HarshwardhanPatil07
changed the title
HarshwardhanPatil07
changed the title
alicefr
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel E2E tests can create daemon pods on multiple nodes. Scope TestControllerMembership's pod lookup to its own node while retaining the exactly-one-running-pod assertion.
TestMidRolloutImageChange permits one reboot at a time but waited in node creation order. When the queued node came first, its eight-minute completion window included waiting for the other node to finish two image transitions. Wait for the already-rebooting node first, then the queued node. Keep the per-node timeout, final-image assertions, and exactly-one-reboot check unchanged.
TestControllerMembership but timed out in the mid-rollout test on Kubernetes 1.35 and 1.36.
Ref: #228